Hi Jarkko, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc5] [cannot apply to tip/x86/core tip/perf/core jeyu/modules-next next-20200714] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/kprobes-Remove-MODULES-dependency/20200715-063746 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e9919e11e219eaa5e8041b7b1a196839143e9125 config: x86_64-fedora-25 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): arch/x86/kernel/text.c: In function 'get_module_load_offset': >> arch/x86/kernel/text.c:30:6: error: implicit declaration of function >> 'get_random_int' [-Werror=implicit-function-declaration] 30 | (get_random_int() % 1024 + 1) * PAGE_SIZE; | ^~~~~~~~~~~~~~ arch/x86/kernel/text.c: At top level: arch/x86/kernel/text.c:42:7: warning: no previous prototype for 'text_alloc' [-Wmissing-prototypes] 42 | void *text_alloc(unsigned long size) | ^~~~~~~~~~ arch/x86/kernel/text.c:62:6: warning: no previous prototype for 'text_free' [-Wmissing-prototypes] 62 | void text_free(void *region) | ^~~~~~~~~ cc1: some warnings being treated as errors vim +/get_random_int +30 arch/x86/kernel/text.c 18 19 static unsigned long get_module_load_offset(void) 20 { 21 if (kaslr_enabled()) { 22 mutex_lock(&module_kaslr_mutex); 23 /* 24 * Calculate the module_load_offset the first time this 25 * code is called. Once calculated it stays the same until 26 * reboot. 27 */ 28 if (module_load_offset == 0) 29 module_load_offset = > 30 (get_random_int() % 1024 + 1) * PAGE_SIZE; 31 mutex_unlock(&module_kaslr_mutex); 32 } 33 return module_load_offset; 34 } 35 #else 36 static unsigned long get_module_load_offset(void) 37 { 38 return 0; 39 } 40 #endif 41 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
