Lee Jones <[email protected]> 於 2020年7月13日 週一 下午6:48寫道： > > On Mon, 13 Jul 2020, Gene Chen wrote: > > > Lee Jones <[email protected]> 於 2020年7月13日 週一 下午2:51寫道： > > > > > > On Fri, 10 Jul 2020, Matthias Brugger wrote: > > > > > > > > > > > > > > > On 07/07/2020 12:30, Gene Chen wrote: > > > > > From: Gene Chen <[email protected]> > > > > > > > > > > Rearrange include file. > > > > > Remove brackets around raw numbers. > > > > > Indicate sub-dev compatible name by using "-" > > > > > Combine mt6360 pmic/ldo resouces into mt6360 regulator resources. > > > > > Rename mt6360_pmu_data by mt6360_data. > > > > > Rename mt6360_pmu by mt6360. > > > > > > > > That seems like a lot of cosmetics. Why is this needed? > > > > If you think that's needed it should be split up in different commits, > > > > each > > > > explaining in the commit message why you do that. > > > > > > Agreed. This set is still not broken up enough. > > > > > > Please place each logical change into its own patch for review. > > > > > > > 1. Rearrange include file. > > After check serveral file about coding style, include file seems sort > > by architecture, not by alphabet > > 2. Remove brackets around raw numbers. > > Due to redundant brackets, another reviewer recommended to delete them. > > 3. Indicate sub-dev compatible name by using "-" > > Suggestion by Lees when review mfd binding document. > > 4. Combine mt6360 pmic/ldo resouces into mt6360 regulator resources. > > Simplify the similar resources object. > > 5. Rename mt6360_pmu_data by mt6360_data. > > Not only include pmu part, but also entire MT6360 IC. > > 6. Rename mt6360_pmu by mt6360. > > Same reason as above. > > > > We try to make code more simpler and easier to understand > > We can also discard changes if patch 1,2,4,5,6 doesn't make any difference. > > I'm not sure what you're trying to say. > > Please place each on of these changes into their own patch. >
I list all topic and reason why we want to modify. Before split into patches, can we discuss which topic reviewer can accept? or I need fix first? > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
