On Mon, Jul 20, 2020 at 9:19 PM <[email protected]> wrote: > > From: Tom Rix <[email protected]> > > clang static analysis reports this repesentative error > > pvr2fb.c:1049:2: warning: 1st function call argument > is an uninitialized value [core.CallAndMessage] > if (*cable_arg) > ^~~~~~~~~~~~~~~ > > Problem is that cable_arg depends on the input loop to > set the cable_arg[0]. If it does not, then some random > value from the stack is used. > > A similar problem exists for output_arg. > > So initialize cable_arg and output_arg.
Adding a zero-initialization is almost never the correct way to deal with these warnings, so one has to be careful doing this. I checked this file, and your patch is absolutely correct here. ;-) > Signed-off-by: Tom Rix <[email protected]> Acked-by: Arnd Bergmann <[email protected]>
