Re: [PATCH v2 2/2] spi: mediatek: add spi support for mt8192 IC

[Matthias Brugger]

On 21/07/2020 14:24, Leilk Liu wrote:
From: "leilk.liu" <leilk....@mediatek.com>

This patch add spi support for mt8192 IC.

Signed-off-by: leilk.liu <leilk....@mediatek.com>
---
  drivers/spi/spi-mt65xx.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
index 6783e12c40c2..3d0d69fe0c69 100644
--- a/drivers/spi/spi-mt65xx.c
+++ b/drivers/spi/spi-mt65xx.c
@@ -170,6 +170,9 @@ static const struct of_device_id mtk_spi_of_match[] = {
        { .compatible = "mediatek,mt8183-spi",
                .data = (void *)&mt8183_compat,
        },
+       { .compatible = "mediatek,mt8192-spi",
+               .data = (void *)&mt6765_compat,
+       },

That's not needed. We will use the fallback compatible which is 
"mediatek,mt6765-spi" which will take the correct DT data. If in the future we 
realize that mt8192 has a difference in the HW we can add the compatible. 
Otherwise with the binding description we should be fine

        {}
  };
  MODULE_DEVICE_TABLE(of, mtk_spi_of_match);