On Mon, Jul 20, 2020 at 10:45 PM David Gow <[email protected]> wrote: > > A number of drivers use devm_platform_ioremap_resource(), but do not (or > did not) explicitly depend on IOMEM[1,2]. Given that the only platform > without HAS_IOMEM seems to be UML, and it has sufficient stubs for > devm_platform_ioremap_resource() and its dependencies to build, we can > remove the HAS_IOMEM requirement here, rather than playing whack-a-mole > with different drivers which don't try to build against ARCH=um. > > The reason this works at the moment is that stub ioremap and iounmap > functions were added to UML to support this sort-of thing[3]. This > particular change doesn't require adding any additional stubs, but there > is possibly room in the future to stub out the remaining iomem functions > (or to provide mock implementations for testing), and get rid of > HAS_IOMEM entirely. > > [1]: https://lkml.org/lkml/2020/6/30/176 > [2]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1e7468bd9d30a21e059af477106dc5588ae52dff > [3]: > https://www.mail-archive.com/[email protected]/msg1405627.html > > Signed-off-by: David Gow <[email protected]>
Reviewed-by: Brendan Higgins <[email protected]>
