On Sun, Jul 19, 2020 at 6:34 PM Xu, Yanfei <[email protected]> wrote: > > > > On 7/20/20 12:57 AM, Al Viro wrote: > > On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote: > >> ping Al Viro > >> > >> Could you please help to review this patch? Thanks a lot. > > > > That's -next, right? As for the patch itself... Frankly, > Yes, it's -next. > > Daniel's patch looks seriously wrong. > Get it. > > Regards, > Yanfei > > * why has O_CLOEXEC been quietly smuggled in? It's > > a userland ABI change, for fsck sake... > > * the double-put you've spotted > > * the whole out: thing - just make it > > if (IS_ERR(file)) { > > userfaultfd_ctx_put(ctx); > > return PTR_ERR(file); > > } > > and be done with that. > >
Adding Lokesh to take a look.
