Pavel

On 7/22/20 2:10 AM, Pavel Machek wrote:
Hi!

+                       ret = fwnode_property_read_u32_array(child,
+                                                            "reg",
+                                                            led_banks,
+                                                            ret);
Move this to subfunction to reduce the indentation? (Or, just refactor
it somehow).
Actually I can just put it all on the same line since the 80 character
requirement is relaxed.
No.

You have too long and too complex function, with too many blocks
inside each other. Please fix it.

I will refactor

Dan


Reply via email to