Hi Randy, On 20/07/2020 21.32, Randy Dunlap wrote: > From: Randy Dunlap <[email protected]> > > SND_SOC_J721E_EVM should not select SND_SOC_PCM3168A_I2C when I2C > is not enabled. That causes build errors, so make this driver's > symbol depend on I2C.
Thank you for the fix! Acked-by: Peter Ujfalusi <[email protected]> > WARNING: unmet direct dependencies detected for SND_SOC_PCM3168A_I2C > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && I2C [=n] > Selected by [m]: > - SND_SOC_J721E_EVM [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] > && (DMA_OMAP [=y] || TI_EDMA [=m] || TI_K3_UDMA [=n] || COMPILE_TEST [=y]) && > (ARCH_K3_J721E_SOC [=n] || COMPILE_TEST [=y]) > > ../sound/soc/codecs/pcm3168a-i2c.c:59:1: warning: data definition has no type > or storage class > module_i2c_driver(pcm3168a_i2c_driver); > ^~~~~~~~~~~~~~~~~ > ../sound/soc/codecs/pcm3168a-i2c.c:59:1: error: type defaults to ‘int’ in > declaration of ‘module_i2c_driver’ [-Werror=implicit-int] > ../sound/soc/codecs/pcm3168a-i2c.c:59:1: warning: parameter names (without > types) in function declaration > ../sound/soc/codecs/pcm3168a-i2c.c:49:26: warning: ‘pcm3168a_i2c_driver’ > defined but not used [-Wunused-variable] > static struct i2c_driver pcm3168a_i2c_driver = { > ^~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > > Fixes: 6748d0559059 ("ASoC: ti: Add custom machine driver for j721e EVM (CPB > and IVI)") > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Peter Ujfalusi <[email protected]> > Cc: Mark Brown <[email protected]> > --- > sound/soc/ti/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200720.orig/sound/soc/ti/Kconfig > +++ linux-next-20200720/sound/soc/ti/Kconfig > @@ -222,6 +222,7 @@ config SND_SOC_DM365_VOICE_CODEC_MODULE > config SND_SOC_J721E_EVM > tristate "SoC Audio support for j721e EVM" > depends on ARCH_K3_J721E_SOC || COMPILE_TEST > + depends on I2C > select SND_SOC_PCM3168A_I2C > select SND_SOC_DAVINCI_MCASP > help > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
