On Sat, Jul 18, 2020 at 12:00:35PM +0200, Christoph Hellwig wrote:
> On Fri, Jul 17, 2020 at 10:55:48PM +0200, Marek Szyprowski wrote:
> > Hi Christoph,
> >
> > On 14.07.2020 21:04, Christoph Hellwig wrote:
> > > Just use d_genocide instead of iterating through the root directory with
> > > cumbersome userspace-like APIs. This also ensures we actually remove
> > > files
> > > that are not direct children of the root entry, which the old code failed
> > > to do.
> > >
> > > Fixes: df52092f3c97 ("fastboot: remove duplicate unpack_to_rootfs()")
> > > Signed-off-by: Christoph Hellwig <[email protected]>
> >
> > This patch breaks initrd support ;-(
> >
> > I use initrd to deploy kernel modules on my test machines. It was
> > automatically mounted on /initrd. /lib/modules is just a symlink to
> > /initrd. I know that initrd support is marked as deprecated, but it
> > would be really nice to give people some time to update their machines
> > before breaking the stuff.
>
> Looks like your setup did rely on the /dev/ notes from the built-in
> initramfs to be preserved.
>
> Can you comment out the call to d_genocide? It seems like for your
> the fact that clean_rootfs didn't actually clean up was a feature and
> not a bug.
>
> I guess the old, pre-2008 code also wouldn't have worked for you in
> that case.
Did you get a chance to try this?
