On Mon, Jul 20, 2020 at 12:38:10PM +0200, Daniel Lezcano wrote: > On 20/07/2020 11:27, Frank Lee wrote: > > HI, > > On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano > > <[email protected]> wrote: > >> > >> On 17/07/2020 09:35, Frank Lee wrote: > >>> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano > >>> <[email protected]> wrote: > >>>> > >>>> On 14/07/2020 09:13, Frank Lee wrote: > >>>>> From: Yangtao Li <[email protected]> > >>>>> > >>>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of > >>>>> calculation. On the other hand, the newer SOC may store other data in > >>>>> the space other than 12bit sensor data. Add mask operation to read data > >>>>> to avoid conversion error. > >>>>> > >>>>> Signed-off-by: Yangtao Li <[email protected]> > >>>>> Reviewed-by: Yangtao Li <[email protected]> > >>>> > >>>> Can you clarify these SoB ? > >>> > >>> Previously I used 'Signed-off-by: Yangtao Li <[email protected]>', > >>> maybe this should be removed directly? > >>> > >>>> > >>>> Frank Lee==Yangtao [email protected][email protected] ? > >>>> > >>> > >>> Yeah. > >> > >> You are not supposed to add reviewed-by yourself. Please remove it. > > > > Should I resend the entire series or just the thermal patch? > > What about those that have been applied. > > I can not speak on behalf of other maintainers. > > The simplest would be to ask them directly. > > If you want to go forward with the thermal changes, you can send them > separately but Maxim's Ack will be needed anyway.
Given that I had a few other comments on the other patches, I guess you can resend the whole series, it will be simpler to track down. Maxime
