On 07/24/20 10:54, Peter Zijlstra wrote:
> On Thu, Jul 16, 2020 at 12:03:45PM +0100, Qais Yousef wrote:
>
> Would you mind terribly if I rename things like so?
Nope, the new name is good for me too.
>
> I tried and failed to come up with a shorter name in general, these
> functions names are somewhat unwieldy. I considered s/_default//.
Can do. Me thinking that maybe we need to sprinkle more comments then. But if
I felt the need for more comments, I can always post another patch on top :-)
If you'd like a shorter name, a slightly shorter one would be
update_uclamp_min_rt()
Thanks
--
Qais Yousef
>
> ---
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -914,7 +914,7 @@ unsigned int uclamp_rq_max_value(struct
> return uclamp_idle_value(rq, clamp_id, clamp_value);
> }
>
> -static void __uclamp_sync_util_min_rt_default_locked(struct task_struct *p)
> +static void __uclamp_update_util_min_rt_default(struct task_struct *p)
> {
> unsigned int default_util_min;
> struct uclamp_se *uc_se;
> @@ -931,7 +931,7 @@ static void __uclamp_sync_util_min_rt_de
> uclamp_se_set(uc_se, default_util_min, false);
> }
>
> -static void __uclamp_sync_util_min_rt_default(struct task_struct *p)
> +static void uclamp_update_util_min_rt_default(struct task_struct *p)
> {
> struct rq_flags rf;
> struct rq *rq;
> @@ -941,7 +941,7 @@ static void __uclamp_sync_util_min_rt_de
>
> /* Protect updates to p->uclamp_* */
> rq = task_rq_lock(p, &rf);
> - __uclamp_sync_util_min_rt_default_locked(p);
> + __uclamp_update_util_min_rt_default(p);
> task_rq_unlock(rq, p, &rf);
> }
>
> @@ -968,7 +968,7 @@ static void uclamp_sync_util_min_rt_defa
>
> rcu_read_lock();
> for_each_process_thread(g, p)
> - __uclamp_sync_util_min_rt_default(p);
> + uclamp_update_util_min_rt_default(p);
> rcu_read_unlock();
> }
>
> @@ -1360,7 +1360,7 @@ static void __setscheduler_uclamp(struct
> * at runtime.
> */
> if (unlikely(rt_task(p) && clamp_id == UCLAMP_MIN))
> - __uclamp_sync_util_min_rt_default_locked(p);
> + __uclamp_update_util_min_rt_default(p);
> else
> uclamp_se_set(uc_se, uclamp_none(clamp_id), false);
>
> @@ -1404,7 +1404,7 @@ static void uclamp_fork(struct task_stru
>
> static void uclamp_post_fork(struct task_struct *p)
> {
> - __uclamp_sync_util_min_rt_default(p);
> + uclamp_update_util_min_rt_default(p);
> }
>
> static void __init init_uclamp_rq(struct rq *rq)
