On Fri, Jul 24, 2020 at 11:08:03AM +0800, Kefeng Wang wrote: > +maillist > > On 2020/7/24 11:04, Kefeng Wang wrote: > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] > > undefined! > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > __cpu_logical_map to fix build issue. > >
I wonder why like other instances in the drivers, the mpidr is not get directly from the cpu. The cpufreq_driver->init call happens when the cpu is being brought online and is executed on the required cpu IIUC. read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. Though we may not add physical hotplug anytime soon, less dependency on this cpu_logical_map is better given that we can resolve this without the need to access the map. -- Regards, Sudeep
