On Fri, Jul 24, 2020 at 04:48:36PM +0200, Sedat Dilek wrote: > On Fri, Jul 24, 2020 at 4:30 PM Arvind Sankar <nived...@alum.mit.edu> wrote: > > > > On Fri, Jul 24, 2020 at 02:50:34AM +0200, Sedat Dilek wrote: > > > On Thu, Jul 23, 2020 at 9:30 PM Nick Terrell <nickrterr...@gmail.com> > > > wrote: > > > > > > > > From: Nick Terrell <terre...@fb.com> > > > > > > > > * Define __DISABLE_EXPORTS in misc.c > > > > > > > > __DISABLE_EXPORTS is defined in misc.c instead of the Makefile because > > > > kaslr.c defines __DISABLE_EXPORTS, and defining it in the Makefile gives > > > > duplicate definition warnings. > > > >
> > I'd have added it to the Makefile and just dropped the definition in > > kaslr.c -- should be no reason for anything in here to use EXPORT_SYMBOL. > > > > I cannot follow - this is no more needed as this was due to some of > your local changes in kaslr.c? > > - Sedat - That part was meant as a comment on the patch, i.e. avoid the duplicate definition warning not by putting it in misc.c instead of the Makefile, but by dropping the definition in kaslr.c.
