Hi Vaibhav, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on block/for-next] [also build test WARNING on v5.8-rc6 next-20200724] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/ata-use-generic-power-management/20200724-190929 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All warnings (new ones prefixed by >>): drivers/ata/pata_triflex.c: In function 'triflex_init_one': >> drivers/ata/pata_triflex.c:186:2: warning: ISO C90 forbids mixed >> declarations and code [-Wdeclaration-after-statement] 186 | static const struct ata_port_info info = { | ^~~~~~ vim +186 drivers/ata/pata_triflex.c 669a5db411d85a1 Jeff Garzik 2006-08-29 176 669a5db411d85a1 Jeff Garzik 2006-08-29 177 static int triflex_init_one(struct pci_dev *dev, const struct pci_device_id *id) 669a5db411d85a1 Jeff Garzik 2006-08-29 178 { 5acd74b592933fd Vaibhav Gupta 2020-07-24 179 /* 5acd74b592933fd Vaibhav Gupta 2020-07-24 180 * We must not disable or powerdown the device. 5acd74b592933fd Vaibhav Gupta 2020-07-24 181 * APM bios refuses to suspend if IDE is not accessible. 5acd74b592933fd Vaibhav Gupta 2020-07-24 182 */ 5acd74b592933fd Vaibhav Gupta 2020-07-24 183 dev->pm_cap = 0; 5acd74b592933fd Vaibhav Gupta 2020-07-24 184 dev_info(&dev->dev, "Disable triflex to be turned off by PCI CORE\n"); 5acd74b592933fd Vaibhav Gupta 2020-07-24 185 1626aeb881236c8 Tejun Heo 2007-05-04 @186 static const struct ata_port_info info = { 1d2808fd3d2d5d2 Jeff Garzik 2007-05-28 187 .flags = ATA_FLAG_SLAVE_POSS, 14bdef982caeda1 Erik Inge Bolsø 2009-03-14 188 .pio_mask = ATA_PIO4, 14bdef982caeda1 Erik Inge Bolsø 2009-03-14 189 .mwdma_mask = ATA_MWDMA2, 669a5db411d85a1 Jeff Garzik 2006-08-29 190 .port_ops = &triflex_port_ops 669a5db411d85a1 Jeff Garzik 2006-08-29 191 }; 1626aeb881236c8 Tejun Heo 2007-05-04 192 const struct ata_port_info *ppi[] = { &info, NULL }; 669a5db411d85a1 Jeff Garzik 2006-08-29 193 06296a1e684bcd4 Joe Perches 2011-04-15 194 ata_print_version_once(&dev->dev, DRV_VERSION); 669a5db411d85a1 Jeff Garzik 2006-08-29 195 1c5afdf7a629d2e Tejun Heo 2010-05-19 196 return ata_pci_bmdma_init_one(dev, ppi, &triflex_sht, NULL, 0); 669a5db411d85a1 Jeff Garzik 2006-08-29 197 } 669a5db411d85a1 Jeff Garzik 2006-08-29 198 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
