On Wed, Jul 29, 2020 at 3:35 AM Vishal Verma <vishal.l.ve...@intel.com> wrote: > > On Mon, 2020-07-27 at 14:37 +0200, Rafael J. Wysocki wrote: > > On Tue, Jul 21, 2020 at 12:24 AM Dan Williams <dan.j.willi...@intel.com> > > wrote: > > > Abstract platform specific mechanics for nvdimm firmware activation > > > behind a handful of generic ops. At the bus level ->activate_state() > > > indicates the unified state (idle, busy, armed) of all DIMMs on the bus, > > > and ->capability() indicates the system state expectations for activate. > > > At the DIMM level ->activate_state() indicates the per-DIMM state, > > > ->activate_result() indicates the outcome of the last activation > > > attempt, and ->arm() attempts to transition the DIMM from 'idle' to > > > 'armed'. > > > > > > A new hibernate_quiet_exec() facility is added to support firmware > > > activation in an OS defined system quiesce state. It leverages the fact > > > that the hibernate-freeze state wants to assert that a memory > > > hibernation snapshot can be taken. This is in contrast to a platform > > > firmware defined quiesce state that may forcefully quiet the memory > > > controller independent of whether an individual device-driver properly > > > supports hibernate-freeze. > > > > > > The libnvdimm sysfs interface is extended to support detection of a > > > firmware activate capability. The mechanism supports enumeration and > > > triggering of firmware activate, optionally in the > > > hibernate_quiet_exec() context. > > > > > > Cc: Pavel Machek <pa...@ucw.cz> > > > Cc: Ira Weiny <ira.we...@intel.com> > > > Cc: Len Brown <len.br...@intel.com> > > > Cc: Jonathan Corbet <cor...@lwn.net> > > > Cc: Dave Jiang <dave.ji...@intel.com> > > > Cc: Vishal Verma <vishal.l.ve...@intel.com> > > > [rafael: hibernate_quiet_exec() proposal] > > > Co-developed-by: "Rafael J. Wysocki" <r...@rjwysocki.net> > > > > IMO it's better to change this to > > > > Co-developed-by: "Rafael J. Wysocki" <rafael.j.wyso...@intel.com> > > > > and please to add > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > > > > to it as per the development process documentation. > > Thanks Rafael, I've fixed this up in the branch I've prepared for the pull > request: > > https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/log/?h=libnvdimm-for-next
LGTM, thanks!
