Make use of the flex_array_size() helper to calculate the size of a
flexible array member within an enclosing structure.

This helper offers defense-in-depth against potential integer overflows
and makes it explicitly clear that we are dealing with a flexible array
member.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
 sound/pci/hda/hda_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 58c698f4d131..453c4ec77c48 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -113,7 +113,7 @@ static int add_conn_list(struct hda_codec *codec, hda_nid_t 
nid, int len,
                return -ENOMEM;
        p->len = len;
        p->nid = nid;
-       memcpy(p->conns, list, len * sizeof(hda_nid_t));
+       memcpy(p->conns, list, flex_array_size(p, conns, len));
        list_add(&p->list, &codec->conn_list);
        return 0;
 }
-- 
2.27.0

Reply via email to