On Sat, Jul 25, 2020 at 11:23:13PM +0100, Lad, Prabhakar wrote: > Hi Niklas, > > On Sat, Jul 25, 2020 at 9:11 AM Niklas <[email protected]> wrote: > > > > Hi Lad, > > > > On 2020-07-24 22:11:31 +0100, Lad, Prabhakar wrote: > > > Hi Niklas, > > > > > > Thank you for the review. > > > > > > On Fri, Jul 24, 2020 at 8:37 PM Niklas <[email protected]> > > > wrote: > > > > > > > > Hi Lad, > > > > > > > > Thanks for your patch. > > > > > > > > On 2020-07-24 15:58:51 +0100, Lad Prabhakar wrote: > > > > > Add a DT property "renesas-vin-ycbcr-8b-g" to select YCbCr422 8-bit > > > > > data > > > > > input pins. > > > > > > > > > > Signed-off-by: Lad Prabhakar <[email protected]> > > > > > Reviewed-by: Biju Das <[email protected]> > > > > > --- > > > > > Documentation/devicetree/bindings/media/renesas,vin.yaml | 13 > > > > > +++++++++++++ > > > > > 1 file changed, 13 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml > > > > > b/Documentation/devicetree/bindings/media/renesas,vin.yaml > > > > > index 53c0a72..7dfb781 100644 > > > > > --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml > > > > > +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml > > > > > @@ -106,6 +106,12 @@ properties: > > > > > > > > > > remote-endpoint: true > > > > > > > > > > + renesas-vin-ycbcr-8b-g: > > > > > > > > I think the preferred format for vendor specific properties are > > > > "<vendor>,<property>". > > > > > > > Indeed and I had it as renesas,vin-ycbcr-8b-g but dt_bindings_check > > > complained about it. > > > > I see, what was the error? > > > CHKDT Documentation/devicetree/bindings/media/renesas,vin.yaml > /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml: > properties:port:properties:endpoint:properties:renesas,vin-ycbcr-8b-g: > {'type': 'boolean', 'description': 'If present this property specifies > to selects VIN_G[7:0] as data pins for YCbCr422 8-bit data.', > 'default': False} is not valid under any of the given schemas > (Possible causes of the failure): > > /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml: > properties:port:properties:endpoint:properties:renesas,vin-ycbcr-8b-g: > 'not' is a required property > > /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml: > properties:ports:properties:port@0:properties:endpoint:properties:renesas,vin-ycbcr-8b-g: > {'type': 'boolean', 'description': 'If present this property specifies > to selects VIN_G[7:0] as data pins for YCbCr422 8-bit data.', > 'default': False} is not valid under any of the given schemas > (Possible causes of the failure): > > /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml: > properties:ports:properties:port@0:properties:endpoint:properties:renesas,vin-ycbcr-8b-g: > 'not' is a required property
The errors here aren't that helpful. The problem is 'default: false' doesn't make sense for a boolean type as false is always not present for DT. Rob
