On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote: > Drivers using serialio are already made available in Kconfig only under > the ISA condition. > > This solves warnings in inb/outb macros on platform that do not have > support for ISA. > > Signed-off-by: Samuel Thibault <[email protected]> > > Index: linux-2.6/drivers/accessibility/speakup/Makefile > =================================================================== > --- linux-2.6.orig/drivers/accessibility/speakup/Makefile > +++ linux-2.6/drivers/accessibility/speakup/Makefile > @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe > obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o > > obj-$(CONFIG_SPEAKUP) += speakup.o > +obj-$(CONFIG_ISA) += serialio.o > speakup-y := \ > buffers.o \ > devsynth.o \ > @@ -25,7 +26,6 @@ speakup-y := \ > keyhelp.o \ > kobjects.o \ > selection.o \ > - serialio.o \ > spk_ttyio.o \ > synth.o \ > thread.o \
Oops, no, I get the following build errors with this patch: ERROR: modpost: "spk_wait_for_xmitr" [drivers/accessibility/speakup/speakup.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_keypc.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_keypc.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_dtlk.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_dtlk.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_decpc.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_decpc.ko] undefined! ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_acntpc.ko] undefined! ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_acntpc.ko] undefined! So something else needs to change here, sorry, dropping this patch for now. thanks, greg k-h
