On Fri, Jun 26, 2020 at 2:35 PM Kees Cook <[email protected]> wrote: > > On Fri, Jun 26, 2020 at 02:09:14PM -0700, Brendan Higgins wrote: > > TAP 14 allows an optional test plan to be emitted before the start of > > the start of testing[1]; this is valuable because it makes it possible > > for a test harness to detect whether the number of tests run matches the > > number of tests expected to be run, ensuring that no tests silently > > failed. > > > > Link[1]: > > https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md#the-plan > > Signed-off-by: Brendan Higgins <[email protected]> > > Reviewed-by: Stephen Boyd <[email protected]> > > Look good, except... > > > diff --git > > a/tools/testing/kunit/test_data/test_is_test_passed-all_passed.log > > b/tools/testing/kunit/test_data/test_is_test_passed-all_passed.log > > index > > 62ebc0288355c4b122ccc18ae2505f971efa57bc..bc0dc8fe35b760b1feb74ec419818dbfae1adb5c > > 100644 > > GIT binary patch > > delta 28 > > jcmbQmGoME|#4$jjEVZaOGe1wk(1goSPtRy09}gP<dC~`u > > > > delta 23 > > ecmbQwGmD2W#4$jjEVZaOGe1wk&}5@94;uhhkp{*9 > > > > diff --git a/tools/testing/kunit/test_data/test_is_test_passed-crash.log > > b/tools/testing/kunit/test_data/test_is_test_passed-crash.log > > index > > 0b249870c8be417a5865bd40a24c8597bb7f5ab1..4d97f6708c4a5ad5bb2ac879e12afca6e816d83d > > 100644 > > GIT binary patch > > delta 15 > > WcmX>hepY;fFN>j`p3z318g2k9Uj*m? > > > > delta 10 > > RcmX>renNbL@5Z2NZU7lr1S$Xk > > > > diff --git a/tools/testing/kunit/test_data/test_is_test_passed-failure.log > > b/tools/testing/kunit/test_data/test_is_test_passed-failure.log > > index > > 9e89d32d5667a59d137f8adacf3a88fdb7f88baf..7a416497e3bec044eefc1535f7d84ee85703ba97 > > 100644 > > GIT binary patch > > delta 28 > > jcmZ3&yOLKp#4$jjEVZaOGe1wk(1goSPtRy0-!wJ=eKrU$ > > > > delta 23 > > ecmZ3<yM&i7#4$jjEVZaOGe1wk&}5_VG&TTPhX-Z= > > What is happening here?? Those logs appear as text to me. Why did git > freak out?
That's because this is all test data; it's all plaintext, but out of necessity some of the test data is kind of munged up and causes checkpatch to complain, so Shuah asked us to mark it as binary since it isn't actually code and so checkpatch will stop flagging it.
