Hi Crt, I love your patch! Yet something to improve:
[auto build test ERROR on iio/togreg] [also build test ERROR on v5.8 next-20200806] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Crt-Mori/iio-temperature-mlx90632-Adding-extended-calibration-option/20200807-051234 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): drivers/iio/temperature/mlx90632.c: In function 'mlx90632_calc_temp_object_extended': >> drivers/iio/temperature/mlx90632.c:606:10: error: too many arguments to >> function 'mlx90632_calc_temp_object_iteration' 606 | temp = mlx90632_calc_temp_object_iteration(temp, object, TAdut, TaTr4, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/temperature/mlx90632.c:533:12: note: declared here 533 | static s32 mlx90632_calc_temp_object_iteration(s32 prev_object_temp, s64 object, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/mlx90632_calc_temp_object_iteration +606 drivers/iio/temperature/mlx90632.c 582 583 static s32 mlx90632_calc_temp_object_extended(s64 object, s64 ambient, s64 reflected, 584 s32 Ea, s32 Eb, s32 Fa, s32 Fb, s32 Ga, 585 s16 Ha, s16 Hb, u16 tmp_emi) 586 { 587 s64 kTA, kTA0, TAdut, TAdut4, Tr4, TaTr4; 588 s64 temp = 25000; 589 s8 i; 590 591 kTA = (Ea * 1000LL) >> 16LL; 592 kTA0 = (Eb * 1000LL) >> 8LL; 593 TAdut = div64_s64(((ambient - kTA0) * 1000000LL), kTA) + 25 * 1000000LL; 594 Tr4 = (div64_long(reflected, 10) + 27315) * 595 (div64_long(reflected, 10) + 27315) * 596 (div64_long(reflected, 10) + 27315) * 597 (div64_long(reflected, 10) + 27315); 598 TAdut4 = (div64_s64(TAdut, 10000LL) + 27315) * 599 (div64_s64(TAdut, 10000LL) + 27315) * 600 (div64_s64(TAdut, 10000LL) + 27315) * 601 (div64_s64(TAdut, 10000LL) + 27315); 602 TaTr4 = Tr4 - div64_long(Tr4 - TAdut4, tmp_emi) * 1000; 603 604 /* Iterations of calculation as described in datasheet */ 605 for (i = 0; i < 5; ++i) { > 606 temp = mlx90632_calc_temp_object_iteration(temp, > object, TAdut, TaTr4, 607 Fa / 2, Fb, Ga, Ha, Hb, 608 tmp_emi); 609 } 610 611 return temp; 612 } 613 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
