Hi Prabhakar, Thank you for the patch.
On Fri, Aug 07, 2020 at 06:49:53PM +0100, Lad Prabhakar wrote: > Add LVDS encoder node to r8a7742 SoC DT. > > Signed-off-by: Lad Prabhakar <[email protected]> > Reviewed-by: Marian-Cristian Rotariu > <[email protected]> > --- > arch/arm/boot/dts/r8a7742.dtsi | 54 ++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7742.dtsi b/arch/arm/boot/dts/r8a7742.dtsi > index a979a4b3de61..a7e66220d63a 100644 > --- a/arch/arm/boot/dts/r8a7742.dtsi > +++ b/arch/arm/boot/dts/r8a7742.dtsi > @@ -1534,11 +1534,65 @@ > port@1 { > reg = <1>; > du_out_lvds0: endpoint { > + remote-endpoint = <&lvds0_in>; > }; > }; > port@2 { > reg = <2>; > du_out_lvds1: endpoint { > + remote-endpoint = <&lvds1_in>; > + }; > + }; > + }; > + }; > + > + lvds0: lvds@feb90000 { > + compatible = "renesas,r8a7742-lvds"; > + reg = <0 0xfeb90000 0 0x1c>; Isn't 0x14 enough for the size ? 0x1c won't hurt though. Same comment below. With or without this addressed, Reviewed-by: Laurent Pinchart <[email protected]> > + clocks = <&cpg CPG_MOD 726>; > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > + resets = <&cpg 726>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds0_in: endpoint { > + remote-endpoint = > <&du_out_lvds0>; > + }; > + }; > + port@1 { > + reg = <1>; > + lvds0_out: endpoint { > + }; > + }; > + }; > + }; > + > + lvds1: lvds@feb94000 { > + compatible = "renesas,r8a7742-lvds"; > + reg = <0 0xfeb94000 0 0x1c>; > + clocks = <&cpg CPG_MOD 725>; > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > + resets = <&cpg 725>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds1_in: endpoint { > + remote-endpoint = > <&du_out_lvds1>; > + }; > + }; > + port@1 { > + reg = <1>; > + lvds1_out: endpoint { > }; > }; > }; -- Regards, Laurent Pinchart
