On 11/08/20 9:48 am, Youling Tang wrote: > There is no need to jump to the "out" tag when "ret < 0", just return > directly to "ret". > > Signed-off-by: Youling Tang <[email protected]>
the patch looks good to me, the commit message doesn't explain the reason for the change. It can be written like: "Previously cleanup() function was called under the out label for both fatal errors (ret < 0) and warnings. Now that cleanup() function is removed, the out label is no longer required. Remove it and return immediately for the fatal errors with ret as return code and 0 for warnings." Reviewed-by: Kamalesh Babulal <[email protected]> -- Kamalesh
