On Mon, 5 Nov 2007 19:09:24 -0600 Matt Mackall <[EMAIL PROTECTED]> wrote:
> Noticed by a Mercurial user. I think this should fix it.
>
"should". That pitter patter sound your hear is little akpm feet running
away.
>
> Index: l/drivers/block/loop.c
> ===================================================================
> --- l.orig/drivers/block/loop.c 2007-11-05 17:50:07.000000000 -0600
> +++ l/drivers/block/loop.c 2007-11-05 19:03:51.000000000 -0600
> @@ -221,6 +221,7 @@ static int do_lo_send_aops(struct loop_d
> offset = pos & ((pgoff_t)PAGE_CACHE_SIZE - 1);
> bv_offs = bvec->bv_offset;
> len = bvec->bv_len;
> + file_update_time(file);
> while (len > 0) {
> sector_t IV;
> unsigned size;
> @@ -299,6 +300,7 @@ static int __do_lo_send_write(struct fil
>
> set_fs(get_ds());
> bw = file->f_op->write(file, buf, len, &pos);
> + file_update_time(file);
> set_fs(old_fs);
> if (likely(bw == len))
> return 0;
Probably makes sense, but bear in mind that we can be fairly deep in
filesystem A functions here, and file_update_time() can do stuff like
starting journal transactions on filesystem B.
I expect the worst we'll see is not-yet-suppressed lockdep warnings and
possibly extra stack windup, but this patch may end up being more complex
than one expects..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
