Hi Jonathan, I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next] [also build test ERROR on tip/x86/core driver-core/driver-core-testing tip/x86/mm linus/master v5.9-rc1 next-20200818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jonathan-Cameron/ACPI-Support-Generic-Initiator-proximity-domains/20200819-010913 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): In file included from include/linux/mmzone.h:17, from include/linux/gfp.h:6, from include/linux/umh.h:4, from include/linux/kmod.h:9, from include/linux/module.h:16, from drivers/acpi/numa/srat.c:10: drivers/acpi/numa/srat.c: In function 'acpi_parse_gi_affinity': >> drivers/acpi/numa/srat.c:385:17: error: 'numa_nodes_parsed' undeclared >> (first use in this function); did you mean 'numa_node_id'? 385 | node_set(node, numa_nodes_parsed); | ^~~~~~~~~~~~~~~~~ include/linux/nodemask.h:127:50: note: in definition of macro 'node_set' 127 | #define node_set(node, dst) __node_set((node), &(dst)) | ^~~ drivers/acpi/numa/srat.c:385:17: note: each undeclared identifier is reported only once for each function it appears in 385 | node_set(node, numa_nodes_parsed); | ^~~~~~~~~~~~~~~~~ include/linux/nodemask.h:127:50: note: in definition of macro 'node_set' 127 | #define node_set(node, dst) __node_set((node), &(dst)) | ^~~ # https://github.com/0day-ci/linux/commit/dc3675892306a46319bde648ffa1ca21034bf6f7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jonathan-Cameron/ACPI-Support-Generic-Initiator-proximity-domains/20200819-010913 git checkout dc3675892306a46319bde648ffa1ca21034bf6f7 vim +385 drivers/acpi/numa/srat.c 364 365 static int __init 366 acpi_parse_gi_affinity(union acpi_subtable_headers *header, 367 const unsigned long end) 368 { 369 struct acpi_srat_generic_affinity *gi_affinity; 370 int node; 371 372 gi_affinity = (struct acpi_srat_generic_affinity *)header; 373 if (!gi_affinity) 374 return -EINVAL; 375 acpi_table_print_srat_entry(&header->common); 376 377 if (!(gi_affinity->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED)) 378 return -EINVAL; 379 380 node = acpi_map_pxm_to_node(gi_affinity->proximity_domain); 381 if (node == NUMA_NO_NODE || node >= MAX_NUMNODES) { 382 pr_err("SRAT: Too many proximity domains.\n"); 383 return -EINVAL; 384 } > 385 node_set(node, numa_nodes_parsed); 386 node_set_state(node, N_GENERIC_INITIATOR); 387 388 return 0; 389 } 390 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
