From: Chen Zhou <[email protected]>

[ Upstream commit 20171723144ca0d057b72e852536992fd371369a ]

Fixes coccicheck warning:

./drivers/media/platform/coda/coda-jpeg.c:331:3-31:
        alloc with no test, possible model on line 354

Add NULL check after kmalloc.

Signed-off-by: Chen Zhou <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
 drivers/media/platform/coda/coda-jpeg.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/coda/coda-jpeg.c 
b/drivers/media/platform/coda/coda-jpeg.c
index 00d19859db500..b11cfbe166dd3 100644
--- a/drivers/media/platform/coda/coda-jpeg.c
+++ b/drivers/media/platform/coda/coda-jpeg.c
@@ -327,8 +327,11 @@ int coda_jpeg_decode_header(struct coda_ctx *ctx, struct 
vb2_buffer *vb)
                                 "only 8-bit quantization tables supported\n");
                        continue;
                }
-               if (!ctx->params.jpeg_qmat_tab[i])
+               if (!ctx->params.jpeg_qmat_tab[i]) {
                        ctx->params.jpeg_qmat_tab[i] = kmalloc(64, GFP_KERNEL);
+                       if (!ctx->params.jpeg_qmat_tab[i])
+                               return -ENOMEM;
+               }
                memcpy(ctx->params.jpeg_qmat_tab[i],
                       quantization_tables[i].start, 64);
        }
-- 
2.25.1

Reply via email to