On 20/08/20 12:23, Maxim Levitsky wrote: > I fully agree that adding local variable is a good idea anyway. > > I was just noting that svm->nested.vmcb is already about the nested > (e.g vmcb12) thus I was thinking that naming this field vmcb12 would be > redundant and not accepted this way.
We want to have both svm->nested.vmcb12 and svm->nested.vmcb02 in there, and hsave is also a VMCB of sort (somewhat like a vmcb01 that is only used while running a nested guest). So it is clearer to write _which_ vmcb it is, and it also helps by making terminology consistent between VMX and SVM. Paolo
