On 8/20/20 11:07 AM, Ahmed S. Darwish wrote: > On Thu, Aug 20, 2020 at 09:35:38AM -0600, Jens Axboe wrote: >> On 8/17/20 9:58 AM, Jens Axboe wrote: >>> On 8/17/20 8:56 AM, Keith Busch wrote: >>>> On Mon, Aug 17, 2020 at 03:50:11PM +0200, Ahmed S. Darwish wrote: >>>>> Hello, >>>>> >>>>> Below v5.9-rc1 commit reliably breaks my boot on a Thinkpad e480 >>>>> laptop. PCI nvme detection fails, and the kernel becomes not able >>>>> anymore to find the rootfs / parse "root=". >>>>> >>>>> Bisecting v5.8=>v5.9-rc1 blames that commit. Reverting it *reliably* >>>>> fixes the problem and makes me able to boot v5.9-rc1. >>>> >>>> The fix is staged in the nvme tree here: >>>> >>>> >>>> http://git.infradead.org/nvme.git/commit/286155561ecd13b6c85a78eaf2880d3baea03b9e >>> >>> That would have been nice to have in -rc1... >> >> And now we're getting very close to shipping items for -rc2, and it's still >> not in. Can we please get the nvme pull request out for -rc2? >> > > I keep wondering that myself. Completely breaking the boot like this is > really not nice -- and for x86-64 laptops no less :-(
To be fair, I've only heard this one complaint about it, so hopefully it's not too widespread. I'm on an x86-64 laptop myself with nvme, and it works just fine :-) > The fix is really small and isolated. "Urgent pull requests", containing > only a fix or two, were created *exactly* for this reson... Totally agree on that, it should have gone in for -rc1. This will be going upstream tomorrow, so the end is near... -- Jens Axboe
