On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: > We would overrun the error_text array if we hit a TIMEOUT condition, > because we were using the error code "ETIMEDOUT" (which is 110) as an > array index. > > We fix the problem by correcting the array index and by providing a > function to retrieve error messages rather than accessing the array > directly. The function includes a bounds check that prevents the array > from being overrun. > > This patch was prepared in response to > https://lkml.org/lkml/2020/8/18/505. > > Signed-off-by: Markus Mayer <[email protected]>
Your Signed-off-by does not match From field. Please run scripts/checkpatch on every patch you send. I fixed it up, assuming [email protected] is the valid email address. > Acked-by: Florian Fainelli <[email protected]> > --- > > Changes since v1: > - Added link of the coverity report to the commit message. > - Added Florian's ack. > - Removed second "const" from get_error_text() return type Florian was so kind to provide you with necessary tags - Fixes and Reported-by. Always include them on resubmit of patches. Thanks, applied. Best regards, Krzysztof
