Re: [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls.

[Takashi Iwai]

On Fri, 21 Aug 2020 20:52:22 +0200,
Connor McAdams wrote:
> 
> +static int ca0132_alt_add_bass_redirection_crossover(struct hda_codec *codec)
> +{
> +     const char *namestr = "Output: Bass Redirection Playback Volume";
> +     struct snd_kcontrol_new knew =
> +             HDA_CODEC_VOLUME_MONO(namestr, BASS_REDIRECTION_XOVER, 1, 0,
> +                             HDA_OUTPUT);

This is no ideal name string for a control element, too.
Better to omit "Output:" prefix at least.


thanks,

Takashi