Hi, On 8/25/20 5:31 PM, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <[email protected]> > > Add usb-typec detection support for Intel LGM SoC based > boards. > > Signed-off-by: Ramuthevar Vadivel Murugan > <[email protected]> > --- > drivers/extcon/extcon-ptn5150.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c > index 8ba706fad887..60355a1b5cb2 100644 > --- a/drivers/extcon/extcon-ptn5150.c > +++ b/drivers/extcon/extcon-ptn5150.c > @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) > return ret; > } > > + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, > + EXTCON_PROP_USB_TYPEC_POLARITY);
extcon_set_property_capability() just sets the capability of EXTCON_PROP_USB_TYPEC_POLARITY property. If you want to set the value (0 or 1) of EXTCON_PROP_USB_TYPEC_POLARITY, we have to call extcon_set_property() function. But, this patch doesn't set the any value of EXTCON_PROP_USB_TYPEC_POLARITY property. Why do you only use extcon_set_property_capability() without the proper extcon_set_property()? > /* Initialize PTN5150 device and print vendor id and version id */ > ret = ptn5150_init_dev_type(info); > if (ret) > -- Best Regards, Chanwoo Choi Samsung Electronics
