On Sat, Aug 22, 2020 at 23:21PM, Vladimir Oltean <olte...@gmail.com> wrote:
> -----Original Message-----
> From: Vladimir Oltean <olte...@gmail.com>
> Sent: 2020年8月22日 23:21
> To: kuldip dwivedi <kuldip.dwiv...@puresoftware.com>
> Cc: Mark Brown <broo...@kernel.org>; linux-...@vger.kernel.org;
> linux-kernel@vger.kernel.org; Qiang Zhao <qiang.z...@nxp.com>; Pankaj
> Bansal <pankaj.ban...@nxp.com>; Varun Sethi <v.se...@nxp.com>; Tanveer
> Alam <tanveer.a...@puresoftware.com>
> Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
>
> On Sat, Aug 22, 2020 at 07:37:25PM +0530, Kuldip Dwivedi wrote:
> > > -----Original Message-----
> > > From: Mark Brown <broo...@kernel.org>
> > > Sent: Friday, August 21, 2020 7:37 PM
> > > To: kuldip dwivedi <kuldip.dwiv...@puresoftware.com>
> > > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Qiang
> > > Zhao <qiang.z...@nxp.com>; Pankaj Bansal <pankaj.ban...@nxp.com>;
> > > Varun Sethi <v.se...@nxp.com>; tanveer
> > > <tanveer.a...@puresoftware.com>
> > > Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
> > >
> > > On Fri, Aug 21, 2020 at 06:40:29PM +0530, kuldip dwivedi wrote:
> > >
> > > > +static const struct acpi_device_id fsl_dspi_acpi_ids[] = {
> > > > + { "NXP0005", .driver_data =
> > (kernel_ulong_t)&devtype_data[LS2085A], },
> > > > + {},
> > > > +};
> > > > +MODULE_DEVICE_TABLE(acpi, fsl_dspi_acpi_ids);
> > >
> > > Does NXP know about this ID assignment from their namespace? ACPI
> > > IDs should be namespaced by whoever's assigning the ID to avoid
> > > collisions.
> > Yes, I got HID from NXP only.
> > >
> > > > - ret = of_property_read_u32(np, "spi-num-chipselects",
> > &cs_num);
> > > > + if (is_acpi_node(pdev->dev.fwnode))
> > > > + ret = device_property_read_u32(&pdev->dev,
> > > > + "spi-num-chipselects", &cs_num);
> > > > + else
> > > > + ret = of_property_read_u32(np,
> > > > + "spi-num-chipselects", &cs_num);
> > >
> > > The whole point with the device property API is that it works with
> > > both DT and ACPI without needing separate parsing, though in this
> > > case I'm wondering why we'd need to specify this in an ACPI system
> > > at all?
> > Understood. Will take care in v2 PATCH
> > >
>
> IMO there is zero reason for the existence of the "spi-num-chipselects"
> property even for DT. We should deprecate it (start ignoring it in existing
> device
> tree deployments) and populate struct fsl_dspi_devtype_data with that info
> based on SoC compatible string.
>
> > > > - of_property_read_u32(np, "bus-num", &bus_num);
> > > > + if (is_acpi_node(pdev->dev.fwnode)) {
> > > > + ret = device_property_read_u32(&pdev->dev,
> > > > + "bus-num",
> > &bus_num);
> > >
> > > This is a bad idea for DT and I can't understand why you'd carry it
> > > over for ACPI - why would an ACPI system ever care about this? It's
> > > Linux internal at the best of times.
> > Will take care in v2 PATCH
>
> Yes, definitely bloatware from the old days. I think this driver needs the
> existing
> device tree bindings rethought a little bit before mindlessly porting them to
> ACPI.
Could you give more details?
Best Regards
Qiang Zhao
