On Fri, Nov 09, 2007 at 12:16:34PM -0800, Andrew Morton wrote:
> On Wed, 7 Nov 2007 23:15:38 +0900
> "Akinobu Mita" <[EMAIL PROTECTED]> wrote:
>
> > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on
> > > CPU_UP_PREPARE)
> > >
> > > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc
> > > ("cpu hotplug: mce: fix cpu hotplug error handling").
> > >
> > > For CPUs not brought up during boot (using maxcpus and additional_cpus
> > > parameters) we don't know whether mce is supported or not at
> > > "CPU_UP_PREPARE"-time.
> > > Thus mce_cpu_callback should be called after the CPU is online.
> >
> > Thank you for finding and fixing the problem.
> > I added two fixes to your patch:
> >
> > - Avoid mce_remove_device() for the CPU that is not correctly initialized
> > by mce_create_device() failure.
> >
> > - make CPU_ONLINE callback always return NOTIFY_OK.
> > Because CPU_ONLINE callback return value is always ignored.
> >
> > > Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]>
> >
> > [EMAIL PROTECTED]: make CPU_ONLINE callback always return NOTIFY_OK]
> > [EMAIL PROTECTED]: avoid mce_remove_device() for not initialized device]
> >
> > Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
>
> Andreas, could you please review and preferably runtime-test this new
> version?
I'll test it today ...
> Assuming that all goes well could one of you please prepare a final patch
> with a complete changelog?
... and can send a final patch after successful testing.
Regards,
Andreas
--
Operating | AMD Saxony Limited Liability Company & Co. KG,
System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Research | Register Court Dresden: HRA 4896, General Partner authorized
Center | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
(OSRC) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
