Miao Xie wrote: > on 2007-11-12 22:08 Tejun Heo wrote: >> It isn't strictly a bug. If the ->show() op fills full PAGE_SIZE and >> returns PAGE_SIZE, the user will get full PAGE_SIZE bytes correctly, so >> it will work. However, considering normal use cases, return value of >> PAGE_SIZE very likely indicates an error condition, so considering it a >> BUG condition is a good idea. >> >> Miao, can you please note that the code works fine with PAGE_SIZE return >> but it's likely to indicate truncated result or overflow in normal use >> cases as a comment on top of the BUG_ON()? >> >> Thanks. > > OK, I did it. > > Signed-off-by: Miao Xie <[EMAIL PROTECTED]>
Acked-by: Tejun Heo <[EMAIL PROTECTED]> Greg, can you please push this one? Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
