On 31.08.2020 14:50, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
>> The USB-C connector bindings require port@0. Such port was already
>> described in DTS but outside of the connector itself. Put it into
>> proper place to fix dtbs_check warnings like:
>>
>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector:
>> ports: 'port@0' is a required property
>>
>> Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
> I'm not sure if topic should be about USB-C, I will call it simply USB
> connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector,
> which has nothing in common with USB Type-C.
>
> Anyway, this patch breaks DWC3 (tested in Device mode) driver operation,
> so something has to be somehow adjusted or fixed. Added CC Andrzej
> Hajda, who actually worked on this.
>
>> ---
>>
>> Not tested on HQ. Please kindly review and test.
>>
>> Best regards,
>> Krzysztof
>> ---
>> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++--------
>> 1 file changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> index 6246cce2a15e..bab6c1addd5f 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> @@ -871,6 +871,13 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> + port@0 {
>> + reg = <0>;
>> + muic_to_usb: endpoint {
>> + remote-endpoint =
>> <&usb_to_muic>;
>> + };
>> + };
>> +
According to not-yet-yaml documentation of dt-bindings (patch 05/10):
> -Required nodes:
> -- any data bus to the connector should be modeled using the OF graph bindings
> - specified in bindings/graph.txt, unless the bus is between parent node and
> - the connector.
This is 'unless' case - muic is parent of the connector, so the port 0 is not
necessary.
>> port@3 {
>> reg = <3>;
>> musb_con_to_mhl: endpoint {
>> @@ -879,14 +886,6 @@
>> };
>> };
>> };
>> -
>> - ports {
>> - port {
>> - muic_to_usb: endpoint {
>> - remote-endpoint =
>> <&usb_to_muic>;
>> - };
>> - };
And this port belongs to MUIC - it describes connection between USB-HOST
and MUIC, it has nothing to do with the connector, and is necessary.
Regards
Andrzej
>> - };
>> };
>>
>> regulators {
> Best regards
