On 2020-09-03 10:08, Zou Cao wrote:
There are multiple gic_data symbol between irq_gic.c and irq_gic_v3.c,
we can see the same symbol name:

        cat /proc/kallsyms | grep gic_data
------>
        ffff80001138f1d0 d gic_data
        ffff80001138f940 d gic_data

Normally CONFIG_ARM_GIC and CONFIG_ARM_GIC_V3 are all enabled, move
the gic_data symbol into different name, it will be friend for
kallsyms_lookup_name to get addr easily.

Signed-off-by: Zou Cao <[email protected]>

I'm sorry, but this kind of change is not acceptable.

It is pure churn, for zero benefit. As an example, give the following
script a go:

awk '{ print $3 }' /proc/kallsyms | sort | uniq -c| awk '$1 > 1 {print}'| sort -n

Are you going to repaint all these symbols?

        M.
--
Jazz is not dead. It just smells funny...

Reply via email to