Hi Krzysztof,
Le mer. 2 sept. 2020 à 21:36, Krzysztof Kozlowski <k...@kernel.org> a
écrit :
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
drivers/mmc/host/jz4740_mmc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/jz4740_mmc.c
b/drivers/mmc/host/jz4740_mmc.c
index 81d71010b474..0c5b52b53303 100644
--- a/drivers/mmc/host/jz4740_mmc.c
+++ b/drivers/mmc/host/jz4740_mmc.c
@@ -991,9 +991,8 @@ static int jz4740_mmc_probe(struct
platform_device* pdev)
ret = mmc_of_parse(mmc);
if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "could not parse device properties: %d\n", ret);
+ dev_err_probe(&pdev->dev, ret,
+ "could not parse device properties\n");
I think you can put that on one line.
With that said:
Reviewed-by: Paul Cercueil <p...@crapouillou.net>
Cheers,
-Paul
goto err_free_host;
}
--
2.17.1
