Hi Joe, I love your patch! Yet something to improve:
[auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on pm/linux-next linus/master v5.9-rc4 next-20200903] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Joe-Perches/drivers-core-Use-sysfs_emit-functions/20200908-021333 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 4024823563d05bbe880885c9987d14a7130801da config: s390-randconfig-s031-20200908 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): drivers/base/memory.c: In function 'phys_index_show': drivers/base/memory.c:122:9: error: implicit declaration of function 'sysfs_emit'; did you mean 'sysfs_init'? [-Werror=implicit-function-declaration] 122 | return sysfs_emit(buf, "%08lx\n", phys_index); | ^~~~~~~~~~ | sysfs_init drivers/base/memory.c: In function 'print_allowed_zone': >> drivers/base/memory.c:317:9: error: implicit declaration of function >> 'sysfs_emit_at'; did you mean 'sysfs_init'? >> [-Werror=implicit-function-declaration] 317 | return sysfs_emit_at(buf, len, " %s", zone->name); | ^~~~~~~~~~~~~ | sysfs_init cc1: some warnings being treated as errors # https://github.com/0day-ci/linux/commit/a8789a23413de463f5e591d57748493242aa4be4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Joe-Perches/drivers-core-Use-sysfs_emit-functions/20200908-021333 git checkout a8789a23413de463f5e591d57748493242aa4be4 vim +317 drivers/base/memory.c 306 307 #ifdef CONFIG_MEMORY_HOTREMOVE 308 static int print_allowed_zone(char *buf, int len, int nid, 309 unsigned long start_pfn, unsigned long nr_pages, 310 int online_type, struct zone *default_zone) 311 { 312 struct zone *zone; 313 314 zone = zone_for_pfn_range(online_type, nid, start_pfn, nr_pages); 315 if (zone == default_zone) 316 return 0; > 317 return sysfs_emit_at(buf, len, " %s", zone->name); 318 } 319 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
