Hi Ian, On Thu, Sep 10, 2020 at 12:26 PM Ian Rogers <irog...@google.com> wrote: > > No need to set os.evsel twice. > > Signed-off-by: Ian Rogers <irog...@google.com>
Acked-by: Namhyung Kim <namhy...@kernel.org> Btw, I think setting the 'out' variable can be moved out of the loop. Thanks Namhyung > --- > tools/perf/util/stat-display.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 493ec372fdec..4b57c0c07632 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -946,7 +946,6 @@ static void print_metric_headers(struct perf_stat_config > *config, > out.print_metric = print_metric_header; > out.new_line = new_line_metric; > out.force_header = true; > - os.evsel = counter; > perf_stat__print_shadow_stats(config, counter, 0, > 0, > &out, > -- > 2.28.0.526.ge36021eeef-goog >
