Hi Rob, Thanks a lot for your comments!
> -----Original Message----- > From: Rob Herring <[email protected]> > Sent: 2020年9月11日 0:48 > To: Z.q. Hou <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; Leo Li > <[email protected]>; [email protected]; [email protected]; > Roy Zang <[email protected]>; [email protected]; > [email protected]; Mingkai Hu <[email protected]>; M.h. Lian > <[email protected]>; Xiaowei Bao <[email protected]> > Subject: Re: [PATCHv7 10/12] arm64: dts: layerscape: Add PCIe EP node for > ls1088a > > On Tue, Aug 11, 2020 at 05:54:39PM +0800, Zhiqiang Hou wrote: > > From: Xiaowei Bao <[email protected]> > > > > Add PCIe EP node for ls1088a to support EP mode. > > > > Signed-off-by: Xiaowei Bao <[email protected]> > > Reviewed-by: Andrew Murray <[email protected]> > > Signed-off-by: Hou Zhiqiang <[email protected]> > > --- > > V7: > > - Rebase the patch without functionality change. > > > > .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 31 > +++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > index 169f4742ae3b..915592141f1b 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > @@ -499,6 +499,17 @@ > > status = "disabled"; > > }; > > > > + pcie_ep@3400000 { > > pci-ep@... The DT node name must be "xxx-xx" style? If yes, the LS1046A EP node also has the name "pcie_ep", it also need to be fixed. Thanks, Zhiqiang > > > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep"; > > + reg = <0x00 0x03400000 0x0 0x00100000 > > + 0x20 0x00000000 0x8 0x00000000>; > > + reg-names = "regs", "addr_space"; > > + num-ib-windows = <24>; > > + num-ob-windows = <128>; > > + max-functions = /bits/ 8 <2>; > > + status = "disabled"; > > + }; > > + > > pcie@3500000 { > > compatible = "fsl,ls1088a-pcie"; > > reg = <0x00 0x03500000 0x0 0x00100000 /* controller > registers */ > > @@ -525,6 +536,16 @@ > > status = "disabled"; > > }; > > > > + pcie_ep@3500000 { > > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep"; > > + reg = <0x00 0x03500000 0x0 0x00100000 > > + 0x28 0x00000000 0x8 0x00000000>; > > + reg-names = "regs", "addr_space"; > > + num-ib-windows = <6>; > > + num-ob-windows = <8>; > > + status = "disabled"; > > + }; > > + > > pcie@3600000 { > > compatible = "fsl,ls1088a-pcie"; > > reg = <0x00 0x03600000 0x0 0x00100000 /* controller > registers */ > > @@ -551,6 +572,16 @@ > > status = "disabled"; > > }; > > > > + pcie_ep@3600000 { > > + compatible = "fsl,ls1088a-pcie-ep","fsl,ls-pcie-ep"; > > + reg = <0x00 0x03600000 0x0 0x00100000 > > + 0x30 0x00000000 0x8 0x00000000>; > > + reg-names = "regs", "addr_space"; > > + num-ib-windows = <6>; > > + num-ob-windows = <8>; > > + status = "disabled"; > > + }; > > + > > smmu: iommu@5000000 { > > compatible = "arm,mmu-500"; > > reg = <0 0x5000000 0 0x800000>; > > -- > > 2.17.1 > >
