On Fri, Sep 11, 2020 at 22:03, Rob Herring <r...@kernel.org> wrote: > -----Original Message----- > From: Rob Herring <r...@kernel.org> > Sent: 2020年9月11日 22:03 > To: Qiang Zhao <qiang.z...@nxp.com> > Cc: a.zu...@towertech.it; alexandre.bell...@bootlin.com; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for > nxp,rtc-2127.txt > > On Wed, Sep 9, 2020 at 9:16 PM Qiang Zhao <qiang.z...@nxp.com> wrote: > > > > On Thu, Sep 10, 2020 at 04:25AM, Rob Herring <r...@kernel.org> wrote: > > > -----Original Message----- > > > From: Rob Herring <r...@kernel.org> > > > Sent: 2020年9月10日 4:25 > > > To: Qiang Zhao <qiang.z...@nxp.com> > > > Cc: a.zu...@towertech.it; alexandre.bell...@bootlin.com; > > > linux-...@vger.kernel.org; devicet...@vger.kernel.org; > > > linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for > > > nxp,rtc-2127.txt > > > > > > On Thu, Aug 27, 2020 at 05:14:39PM +0800, Qiang Zhao wrote: > > > > From: Zhao Qiang <qiang.z...@nxp.com> > > > >
Please help to review as below, if it is ok, I will send the new version patch. Thank you! diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml new file mode 100644 index 0000000..809dd59 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/nxp,pcf2127.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: PCF RTCs + +maintainers: + - Qiang Zhao <qiang.z...@nxp.com> + +allOf: + - $ref: "rtc.yaml#" + +properties: + compatible: + enum: + - nxp,pcf2127 + - nxp,pcf2129 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + no-watchdog: + maxItems: 1 + + start-year: true + +required: + - compatible + - reg + +additionalProperties: false + +... > > Documentation/devicetree/writing-schema.rst and about 1000 examples in the > kernel tree. > > Rob
