On Tue 15-09-20 15:47:37, Chris Down wrote:
> zangchun...@bytedance.com writes:
> > +           if (signal_pending(current))
> > +                   return;
> 
> This doesn't match your patch title, please update it. :-)

I have to admit I have completely missed this and I think that this
should better be fatal_signal_pending because that would make sure that
the userspace will not see an incomplete operation. This is a general
practice for other bail outs as well.

> After that, you can add:
> 
> Acked-by: Chris Down <ch...@chrisdown.name>

-- 
Michal Hocko
SUSE Labs

Reply via email to