On 15/09/2020 21:45, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Fri, Sep 4, 2020 at 6:17 PM Neil Armstrong <narmstr...@baylibre.com> wrote:
>>
>> The Power Controller in the Amlogic AXG SoCs is similar to the GXL one
>> but with less VPU memory domains to enable and a supplementary Audio
>> memory power domain.
>>
>> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com>
> I have three small comments below - no show-stoppers though:
> Acked-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
>
> [...]
>> +static struct meson_ee_pwrc_mem_domain axg_pwrc_mem_vpu[] = {
>> + VPU_MEMPD(HHI_VPU_MEM_PD_REG0),
>> + VPU_HHI_MEMPD(HHI_MEM_PD_REG0),
>> +};
>> +
> I would put this above the g12a one
Sure, I'll change for v2
>
> [...]
>> +static struct meson_ee_pwrc_domain_desc axg_pwrc_domains[] = {
>> + [PWRC_AXG_VPU_ID] = VPU_PD("VPU", &gx_pwrc_vpu, axg_pwrc_mem_vpu,
>> + pwrc_ee_get_power, 5, 2),
>> + [PWRC_AXG_ETHERNET_MEM_ID] = MEM_PD("ETH", meson_pwrc_mem_eth),
>> + [PWRC_AXG_AUDIO_ID] = MEM_PD("AUDIO", axg_pwrc_mem_audio),
>> +};
>> +
> same here
Sure, I'll change for v2
>
> [...]
>> static struct meson_ee_pwrc_domain_data meson_ee_gxbb_pwrc_data = {
>> .count = ARRAY_SIZE(gxbb_pwrc_domains),
>> .domains = gxbb_pwrc_domains,
>> @@ -566,6 +588,10 @@ static const struct of_device_id
>> meson_ee_pwrc_match_table[] = {
>> .compatible = "amlogic,meson-gxbb-pwrc",
>> .data = &meson_ee_gxbb_pwrc_data,
>> },
>> + {
>> + .compatible = "amlogic,meson-axg-pwrc",
>> + .data = &meson_ee_axg_pwrc_data,
>> + },
> this one I would put above the GXBB one
Sure, I'll change for v2
Thanks for the review,
Neil
>
>
> Best regards,
> Martin
>
