Many error paths in __regmap_init rely on ret being pre-initialised to
-EINVAL, add an extra initialisation in after the new call to
regmap_set_name.

Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for debugfs 
init delays")
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Charles Keepax <ckee...@opensource.cirrus.com>
---
 drivers/base/regmap/regmap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index b24f14ea96d8a..4c2a114584236 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -723,6 +723,8 @@ struct regmap *__regmap_init(struct device *dev,
        if (ret)
                goto err_map;
 
+       ret = -EINVAL; /* Later error paths rely on this */
+
        if (config->disable_locking) {
                map->lock = map->unlock = regmap_lock_unlock_none;
                map->can_sleep = config->can_sleep;
-- 
2.11.0

Reply via email to