On Sat, Nov 17, 2007 at 05:33:27PM +0100, Andreas Mohr wrote: > Hi, > > On Wed, Nov 14, 2007 at 02:46:27PM -0800, Randy Dunlap wrote: > > On Mon, 5 Nov 2007 20:58:27 +0100 Andreas Mohr wrote: > > > Feel free to go ahead, otherwise I'll try another patch sometime soon. > > > All I care about is that the result works on (at least) > > > one shell implementation _more_ than the current status ;) > > > > Hi Andreas, > > > > Can you comment on (or test) whether this patch is sufficient > > for your needs? And if so, is the Signed-off-by: A.M. OK? > > Sorry, no, using dash (0.5.3-5) there's still a remaining > > $ linux-2.6.22/scripts/patch-kernel linux-2.6.22 /usr/src/patch-2.6 > Current kernel version is 2.6.22 ( Holy Dancing Manatees, Batman!) > linux-2.6.22/scripts/patch-kernel: 207: Syntax error: Bad substitution > > error in the > > # strip EXTRAVERSION to just a number (drop leading '.' and trailing > additions) > EXTRAVER= > if [ x$EXTRAVERSION != "x" ] > then > >>> [l.207] if [ ${EXTRAVERSION:0:1} == "." ]; then > EXTRAVER=${EXTRAVERSION:1} > else > EXTRAVER=$EXTRAVERSION > fi > EXTRAVER=${EXTRAVER%%[[:punct:]]*} > #echo "$PNAME: changing EXTRAVERSION from $EXTRAVERSION to $EXTRAVER" > fi > > part, which the sed expression (moderately successfully) tried to > take care of. > > The good part of the story is that the current corrected almost fully > working version still works with bash (3.1dfsg-8), just like the > original patch-kernel version.
Could you (or Randy) fix it up with the comment from Herbert and submit the final version to me (with proper changelog and s-o-b). Thanks, Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/