On 9/21/20 7:40 AM, Colin King wrote: > From: Colin Ian King <[email protected]> > > The error return ret is not being check with an if statement and > currently the code always returns leaving the following code as > dead code. Fix this by adding in the missing if statement. > > Addresses-Coverity: ("Structurally dead code") > Fixes: ad3d29c77e1e ("PCI: brcmstb: Add control of rescal reset") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/pci/controller/pcie-brcmstb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c > b/drivers/pci/controller/pcie-brcmstb.c > index 7a3ff4632e7c..cb0c11b7308e 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -1154,6 +1154,7 @@ static int brcm_pcie_resume(struct device *dev) > clk_prepare_enable(pcie->clk); > > ret = brcm_phy_start(pcie); > + if (ret) > return ret;
Maybe this should also disable the clock if we failed to start the PHY somehow. -- Florian
