On 2020-09-30 6:43 p.m., Joe Perches wrote: > On Wed, 2020-09-30 at 18:28 -0700, Scott Branden wrote: >> Add message support in order to be able to communicate >> to VK card via message queues. > trivia: will remove comment below. > >> +/* structure that is used to faciliate displaying of register content */ >> +struct bcm_vk_entry { >> + const u32 mask; >> + const u32 exp_val; >> + const char *str; >> +}; > [] I think you want a newline added here. >> +/* >> + * alerts that could be generated from peer >> + */ >> +struct bcm_vk_entry const bcm_vk_peer_err[BCM_VK_PEER_ERR_NUM] = { > const struct bcm_vk_entry will add the const's > >> + {ERR_LOG_UECC, ERR_LOG_UECC, "uecc"}, >> + {ERR_LOG_SSIM_BUSY, ERR_LOG_SSIM_BUSY, "ssim_busy"}, >> + {ERR_LOG_AFBC_BUSY, ERR_LOG_AFBC_BUSY, "afbc_busy"}, >> + {ERR_LOG_HIGH_TEMP_ERR, ERR_LOG_HIGH_TEMP_ERR, "high_temp"}, >> + {ERR_LOG_WDOG_TIMEOUT, ERR_LOG_WDOG_TIMEOUT, "wdog_timeout"}, >> + {ERR_LOG_SYS_FAULT, ERR_LOG_SYS_FAULT, "sys_fault"}, >> + {ERR_LOG_RAMDUMP, ERR_LOG_RAMDUMP, "ramdump"}, >> + {ERR_LOG_MEM_ALLOC_FAIL, ERR_LOG_MEM_ALLOC_FAIL, "malloc_fail warn"}, >> + {ERR_LOG_LOW_TEMP_WARN, ERR_LOG_LOW_TEMP_WARN, "low_temp warn"}, >> + {ERR_LOG_ECC, ERR_LOG_ECC, "ecc"}, >> +}; >> + >> +/* alerts detected by the host */ >> +struct bcm_vk_entry const bcm_vk_host_err[BCM_VK_HOST_ERR_NUM] = { > here too thanks. > >> + {ERR_LOG_HOST_PCIE_DWN, ERR_LOG_HOST_PCIE_DWN, "PCIe_down"}, >> + {ERR_LOG_HOST_HB_FAIL, ERR_LOG_HOST_HB_FAIL, "hb_fail"}, >> + {ERR_LOG_HOST_INTF_V_FAIL, ERR_LOG_HOST_INTF_V_FAIL, "intf_ver_fail"}, >> +}; > [] >> @@ -970,6 +1251,9 @@ static int bcm_vk_probe(struct pci_dev *pdev, const >> struct pci_device_id *ent) >> } >> } >> >> + /* enable hb */ >> + bcm_vk_hb_init(vk); >> + >> dev_dbg(dev, "BCM-VK:%u created, 0x%p\n", id, vk); > Not much purpose in displaying the pointer. ok. > > thanks for the review.
smime.p7s
Description: S/MIME Cryptographic Signature