On Fri, 2 Oct 2020 10:18:41 -0500 Josh Poimboeuf <jpoim...@redhat.com> wrote:
> On Thu, Oct 01, 2020 at 12:17:25AM +0200, Vasily Gorbik wrote: > > From: Martin Schwidefsky <schwidef...@de.ibm.com> > > > > Currently objtool seems to be the only tool from build tools needed > > which breaks x86 cross compilation on big endian systems. Make the x86 > > instruction decoder of the objtool usable on big endian machines. > > > > Signed-off-by: Martin Schwidefsky <schwidef...@de.ibm.com> > > Co-developed-by: Vasily Gorbik <g...@linux.ibm.com> > > Signed-off-by: Vasily Gorbik <g...@linux.ibm.com> > > Since this changes the decoder (which is shared with the kernel), please > prefix the subject with "x86/insn:" instead of "objtool". Thanks for pointing it. > > This patch is a bit ugly, but I don't necessarily have a better idea. > > Masami? Yeah, agreed. Maybe we can split that part in different header, but that makes it more ugly. And code itself looks good to me. (I like insn_field_set() idea :) ) Acked-by: Masami Hiramatsu <mhira...@kernel.org> Thank you! > -- > Josh > -- Masami Hiramatsu <mhira...@kernel.org>
