On 10/5/20 4:50 AM, Alexandru Ardelean wrote:
> This one was caught by the compiler.
> Adds missing break statements, which look omitted by accident.
>
Most definitely.
> Fixes: 599a5ac5f96c ("hwmon: (pmbus/max34440) Fix/add missing break
> statements")
This should point to the culprit.
> Signed-off-by: Alexandru Ardelean <[email protected]>
> ---
>
> Maybe the lkp bot also reported this [by now].
> I just bumped into this now, trying to work on another driver.
> Now whether this gets applied, or a V2 is created, is not important from my
> side.
>
Thanks, folded into the original patch.
Guenter
> This is a heads-up [from my side].
>
> drivers/hwmon/pmbus/max34440.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/max34440.c b/drivers/hwmon/pmbus/max34440.c
> index bdea52996580..f4cb196aaaf3 100644
> --- a/drivers/hwmon/pmbus/max34440.c
> +++ b/drivers/hwmon/pmbus/max34440.c
> @@ -61,9 +61,11 @@ static int max34440_read_word_data(struct i2c_client
> *client, int page,
> case PMBUS_IOUT_OC_FAULT_LIMIT:
> ret = pmbus_read_word_data(client, page, phase,
> MAX34440_IOUT_OC_FAULT_LIMIT);
> + break;
> case PMBUS_IOUT_OC_WARN_LIMIT:
> ret = pmbus_read_word_data(client, page, phase,
> MAX34440_IOUT_OC_WARN_LIMIT);
> + break;
> case PMBUS_VIRT_READ_VOUT_MIN:
> ret = pmbus_read_word_data(client, page, phase,
> MAX34440_MFR_VOUT_MIN);
> @@ -133,9 +135,11 @@ static int max34440_write_word_data(struct i2c_client
> *client, int page,
> case PMBUS_IOUT_OC_FAULT_LIMIT:
> ret = pmbus_write_word_data(client, page,
> MAX34440_IOUT_OC_FAULT_LIMIT,
> word);
> + break;
> case PMBUS_IOUT_OC_WARN_LIMIT:
> ret = pmbus_write_word_data(client, page,
> MAX34440_IOUT_OC_WARN_LIMIT,
> word);
> + break;
> case PMBUS_VIRT_RESET_POUT_HISTORY:
> ret = pmbus_write_word_data(client, page,
> MAX34446_MFR_POUT_PEAK, 0);
>
