On 10/8/2020 3:33 PM, Wolfram Sang wrote:
On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote:
The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
is used for i2c, so disable it.

https://patchwork.kernel.org/patch/11133827/
Signed-off-by: Caleb Connolly <ca...@connolly.tech>
Reviewed-by: Mukesh Kumar Savaliya <msava...@codeaurora.org>
May I ask for a quick review here, so we can get this into 5.9 if
qcom-geni maintainers agree this is good to go?

---
  drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c 
b/drivers/i2c/busses/i2c-qcom-geni.c
index dead5db3315a..50a0674a6553 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, 
struct i2c_msg *msg,
        struct geni_se *se = &gi2c->se;
        size_t len = msg->len;
- if (!of_machine_is_compatible("lenovo,yoga-c630"))
+       if (!of_machine_is_compatible("lenovo,yoga-c630") &&
+           !of_machine_is_compatible("oneplus,oneplus6"))
                dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
if (dma_buf)
@@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, 
struct i2c_msg *msg,
        struct geni_se *se = &gi2c->se;
        size_t len = msg->len;
- if (!of_machine_is_compatible("lenovo,yoga-c630"))
+       if (!of_machine_is_compatible("lenovo,yoga-c630") &&
+           !of_machine_is_compatible("oneplus,oneplus6"))
                dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
if (dma_buf)
--
2.28.0


Reply via email to