Hi Shihlun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.9]
[cannot apply to lee-mfd/for-mfd-next next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
b5fc7a89e58bcc059a3d5e4db79c481fb437de59
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # 
https://github.com/0day-ci/linux/commit/ac7622765e9bf99891a911be7a47e27b5afe3a35
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
        git checkout ac7622765e9bf99891a911be7a47e27b5afe3a35
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> drivers/mfd/ahc1ec0-hwmon.c:1280:6: warning: no previous prototype for 
>> 'adv_ec_init_hwmon_profile' [-Wmissing-prototypes]
    1280 | void adv_ec_init_hwmon_profile(u32 profile, struct 
adv_ec_platform_data *plat_data)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/adv_ec_init_hwmon_profile +1280 drivers/mfd/ahc1ec0-hwmon.c

  1279  
> 1280  void adv_ec_init_hwmon_profile(u32 profile, struct adv_ec_platform_data 
> *plat_data)
  1281  {
  1282          int i;
  1283          struct HW_PIN_TBL *ptbl = &lmsensor_data.pin_tbl;
  1284          struct Dynamic_Tab *dym_tbl = plat_data->dym_tbl;
  1285  
  1286          lmsensor_data.bios_product_name = plat_data->bios_product_name;
  1287          lmsensor_data.profile = &advec_profile[profile];
  1288  
  1289          for (i = 0; i < EC_MAX_TBL_NUM ; i++) {
  1290                  switch (dym_tbl[i].DeviceID) {
  1291                  case EC_DID_CMOSBAT:
  1292                          ptbl->vbat[0] = dym_tbl[i].HWPinNumber;
  1293                          ptbl->vbat[1] = 1;
  1294                          break;
  1295                  case EC_DID_CMOSBAT_X2:
  1296                          ptbl->vbat[0] = dym_tbl[i].HWPinNumber;
  1297                          ptbl->vbat[1] = 2;
  1298                          break;
  1299                  case EC_DID_CMOSBAT_X10:
  1300                          ptbl->vbat[0] = dym_tbl[i].HWPinNumber;
  1301                          ptbl->vbat[1] = 10;
  1302                          break;
  1303                  case EC_DID_5VS0:
  1304                  case EC_DID_5VS5:
  1305                          ptbl->v5[0] = dym_tbl[i].HWPinNumber;
  1306                          ptbl->v5[1] = 1;
  1307                          break;
  1308                  case EC_DID_5VS0_X2:
  1309                  case EC_DID_5VS5_X2:
  1310                          ptbl->v5[0] = dym_tbl[i].HWPinNumber;
  1311                          ptbl->v5[1] = 2;
  1312                          break;
  1313                  case EC_DID_5VS0_X10:
  1314                  case EC_DID_5VS5_X10:
  1315                          ptbl->v5[0] = dym_tbl[i].HWPinNumber;
  1316                          ptbl->v5[1] = 10;
  1317                          break;
  1318                  case EC_DID_12VS0:
  1319                          ptbl->v12[0] = dym_tbl[i].HWPinNumber;
  1320                          ptbl->v12[1] = 1;
  1321                          break;
  1322                  case EC_DID_12VS0_X2:
  1323                          ptbl->v12[0] = dym_tbl[i].HWPinNumber;
  1324                          ptbl->v12[1] = 2;
  1325                          break;
  1326                  case EC_DID_12VS0_X10:
  1327                          ptbl->v12[0] = dym_tbl[i].HWPinNumber;
  1328                          ptbl->v12[1] = 10;
  1329                          break;
  1330                  case EC_DID_VCOREA:
  1331                  case EC_DID_VCOREB:
  1332                          ptbl->vcore[0] = dym_tbl[i].HWPinNumber;
  1333                          ptbl->vcore[1] = 1;
  1334                          break;
  1335                  case EC_DID_VCOREA_X2:
  1336                  case EC_DID_VCOREB_X2:
  1337                          ptbl->vcore[0] = dym_tbl[i].HWPinNumber;
  1338                          ptbl->vcore[1] = 2;
  1339                          break;
  1340                  case EC_DID_VCOREA_X10:
  1341                  case EC_DID_VCOREB_X10:
  1342                          ptbl->vcore[0] = dym_tbl[i].HWPinNumber;
  1343                          ptbl->vcore[1] = 10;
  1344                          break;
  1345                  case EC_DID_DC:
  1346                          ptbl->vdc[0] = dym_tbl[i].HWPinNumber;
  1347                          ptbl->vdc[1] = 1;
  1348                          break;
  1349                  case EC_DID_DC_X2:
  1350                          ptbl->vdc[0] = dym_tbl[i].HWPinNumber;
  1351                          ptbl->vdc[1] = 2;
  1352                          break;
  1353                  case EC_DID_DC_X10:
  1354                          ptbl->vdc[0] = dym_tbl[i].HWPinNumber;
  1355                          ptbl->vdc[1] = 10;
  1356                          break;
  1357                  case EC_DID_CURRENT:
  1358                          ptbl->ec_current[0] = dym_tbl[i].HWPinNumber;
  1359                          ptbl->ec_current[1] = 1;
  1360                          break;
  1361                  case EC_DID_SMBOEM0:
  1362                          lmsensor_data.ec_smboem0.HWPinNumber = 
dym_tbl[i].HWPinNumber;
  1363                          break;
  1364                  default:
  1365                          break;
  1366                  }
  1367          }
  1368  }
  1369  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

Reply via email to